Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regression Linux i386 workflow #3356

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

mfundul
Copy link
Contributor

@mfundul mfundul commented Jun 23, 2021

Change the postgresql ftp URL from snapshot/ to source/.

@mfundul mfundul requested review from svenklemm, erimatnor, mkindahl and a team June 23, 2021 09:50
@mfundul mfundul marked this pull request as ready for review June 23, 2021 09:50
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #3356 (059eeb4) into master (9eec2a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3356   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         212      212           
  Lines       35588    35588           
=======================================
  Hits        32239    32239           
  Misses       3349     3349           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eec2a5...059eeb4. Read the comment docs.

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, but please explain in the commit message why it is necessary to change the FTP URL not just what the commit does.

.github/workflows/linux-32bit-build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/linux-32bit-build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/linux-32bit-build-and-test.yaml Outdated Show resolved Hide resolved
Change the postgresql ftp URL from snapshot/ to source/. This way we
do not need to react to every new commit upstream, but only whenever
the postgresql minor version changes.

Co-authored-by: Mats Kindahl <mats.kindahl@gmail.com>
@mfundul mfundul merged commit c82b5c3 into timescale:master Jun 23, 2021
@mfundul mfundul deleted the fix-i386-regression-test branch June 23, 2021 10:30
@mfundul mfundul self-assigned this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants